bug#53153: package-quickstart: unusual autoload form in selectrum gives byte-compilation warning

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> This unusual arrangement means that we end up with this interesting form
> in package-quickstart.el (pretty-printed):
>
>   (define-minor-mode selectrum-mode
>     "Minor mode to use Selectrum for `completing-read'."
>     :global t

[...]

> 1. Does it make sense for Emacs to be complaining about a defcustom
>    here?  AFAICT, there is no defcustom in the above form.  Do we care,
>    or is this use case just unsupported?

define-minor-mode expands to (among many other things) a defcustom form,
I think?

> 2. I guess the other question is why `selectrum-mode' is not just in its
>    own file, if startup speed is of the essence.  Maybe Stefan Monnier
>    has something to add here.

Yeah, it seems like a pretty weird thing to do.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no