[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining
From: |
Eli Zaretskii |
Subject: |
bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining |
Date: |
Tue, 18 Jan 2022 16:45:07 +0200 |
> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Mon, 17 Jan 2022 22:19:59 -0700
>
> I've got it working. Please let me know what you think of the attached.
Thanks.
I see you play some games with shell syntactic rules and such: IME,
these are often tricky enough to defeat simplistic handling. For
example, does this support commands that have redirection operators
_before_ the first verb? It's allowed in every shell I've seen,
albeit very rarely used.
I think Robert found another possible issue.
> +(cl-macrolet
> + ((deftest (name input expected)
> + (let ((result (gensym)))
> + `(ert-deftest ,name ()
> + (let* ((shell-file-name "sh") (shell-command-switch "-c")
> + (,result
> + (with-temp-eshell (eshell-parse-command ,input))))
> + ;; Strip `eshell-trap-errors'.
> + (should (equal (cadr ,result) ,expected)))))))
> +
> + (deftest em-extpipe-test-1
> + "foo *| bar >baz"
> + '(eshell-named-command "sh"
> + (list "-c" "foo | bar >baz")))
Why do these tests only look for 'sh' as the shell? What is the
importance of the shell for this purpose?
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Sean Whitton, 2022/01/18
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Robert Pluim, 2022/01/18
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining,
Eli Zaretskii <=
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Sean Whitton, 2022/01/18
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Eli Zaretskii, 2022/01/18
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Sean Whitton, 2022/01/18
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Eli Zaretskii, 2022/01/19
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Sean Whitton, 2022/01/19
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Eli Zaretskii, 2022/01/20
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Sean Whitton, 2022/01/20
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Eli Zaretskii, 2022/01/21
- bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Sean Whitton, 2022/01/21
bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining, Sean Whitton, 2022/01/18