[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51883: 29.0.50; Command to get accidentally deleted frames back
From: |
Juri Linkov |
Subject: |
bug#51883: 29.0.50; Command to get accidentally deleted frames back |
Date: |
Thu, 27 Jan 2022 19:21:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> Which other parameters would you suggest to remove (on master)?
>
> It would be pretentious to answer that question. The comment starting
> at line 261 of frameset.el tells that
>
> ;; - `window-id', `outer-window-id', `parent-id': They are assigned
> ;; automatically and cannot be set, so keeping them is harmless, but they
> ;; add clutter. `window-system' is similar: it's assigned at frame
> ;; creation, and does not serve any useful purpose later.
>
> so according to that comment, leaving 'parent-id' in the list should not
> have caused any problems. Thanks to Juri, we know better now.
I confirm that removing 'parent-id' is sufficient to fix the bug in Emacs 28.
So here is the minimal patch for the release branch:
diff --git a/lisp/frame.el b/lisp/frame.el
index 86c52dc438..69119b4c24 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -798,8 +798,9 @@ clone-frame
(windows (unless no-windows
(window-state-get (frame-root-window frame))))
(default-frame-alist
- (seq-remove (lambda (elem) (eq (car elem) 'name))
- (frame-parameters frame)))
+ (seq-remove (lambda (elem)
+ (memq (car elem) '(name parent-id)))
+ (frame-parameters frame)))
(new-frame (make-frame)))
(when windows
(window-state-put windows (frame-root-window new-frame) 'safe))
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, (continued)
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Stefan Monnier, 2022/01/22
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Juri Linkov, 2022/01/23
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Stefan Monnier, 2022/01/23
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Juri Linkov, 2022/01/23
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Stefan Monnier, 2022/01/23
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Juri Linkov, 2022/01/24
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Eli Zaretskii, 2022/01/24
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, martin rudalics, 2022/01/25
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Eli Zaretskii, 2022/01/25
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, martin rudalics, 2022/01/25
- bug#51883: 29.0.50; Command to get accidentally deleted frames back,
Juri Linkov <=
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Eli Zaretskii, 2022/01/27
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Juri Linkov, 2022/01/27
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Stefan Monnier, 2022/01/24
- bug#51883: 29.0.50; Command to get accidentally deleted frames back, Juri Linkov, 2022/01/27
bug#51883: 29.0.50; Command to get accidentally deleted frames back, Juri Linkov, 2022/01/30
bug#51883: 29.0.50; Command to get accidentally deleted frames back, Juri Linkov, 2022/01/22