[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa
From: |
Robert Pluim |
Subject: |
bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa |
Date: |
Fri, 28 Jan 2022 09:17:24 +0100 |
>>>>> On Thu, 27 Jan 2022 20:58:11 +0000, Alan Third <alan@idiocy.org> said:
Alan> On Thu, Jan 27, 2022 at 12:06:36PM +0100, Robert Pluim wrote:
>> >>>>> On Wed, 26 Jan 2022 17:46:15 +0100, Lars Ingebrigtsen
<larsi@gnus.org> said:
>>
Lars> David Benjamin <davidben@google.com> writes:
>> >> Here's a patch for something that's been bugging me. This makes Cmd-`
>> >> cycle through only the current space's windows, which is consistent
>> >> with other programs on OS X. It also matches the behavior of
>> >> other-frame on X11 for window managers that implement virtual desktops
>> >> by mapping and unmapping windows. The patch is attached.
>>
Lars> Perhaps Alan has a comment here; added to the CCs.
>>
>> Please let's apply this. Please. Pretty please. Pretty please with sugar
on
>> top. Please.
>>
>> Iʼve rebased it to master and attach it here.
>>
>> Did I mention I like it?
Alan> I'm afraid I don't much. It looks like the updateVisibility method
Alan> doesn't actually do enough to replace the windowDidBecomeKey method.
Thatʼs an artifact of me screwing up the patch, I think. But it
probably needs updating anyway, as Po pointed out.
Alan> It also needs a good clean. For example there's a hunk that appears to
Alan> just be removing a single blank line and most of the #ifdef's are
Alan> redundant. I guess some of the weirdness in it is just because it's so
Alan> old.
Sorry, I messed up the rebase. The attached should be better.
0001-Make-other-frame-cycle-on-current-space-only-nsterm.patch
Description: Text Data
Robert
--
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, (continued)
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Robert Pluim, 2022/01/27
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Po Lu, 2022/01/27
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Robert Pluim, 2022/01/27
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Po Lu, 2022/01/27
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Robert Pluim, 2022/01/28
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Po Lu, 2022/01/28
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Robert Pluim, 2022/01/28
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Po Lu, 2022/01/28
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Robert Pluim, 2022/01/28
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa, Po Lu, 2022/01/28
Message not available
- bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa,
Robert Pluim <=