|
From: | Jim Porter |
Subject: | bug#53715: 29.0.50; [PATCH] Improve correctness of pipelines in Eshell |
Date: | Wed, 2 Feb 2022 13:01:16 -0800 |
On 2/2/2022 11:49 AM, Lars Ingebrigtsen wrote:
Jim Porter <jporterbugs@gmail.com> writes:Sorry, I forgot to mention that since the second patch updates a defsubst (`eshell-interactive-process'), you'll need to recompile all the files that might use it, so `make boostrap' or `touch lisp/eshell/*.el test/lisp/eshell/*.el && make'. That should make these tests pass.I did remove all the .elc files in lisp/eshell and rebuilt, but the tests still failed. (I didn't try to delete the test elc files, though.)
Ah, I think I see the issue. I should have updated `eshell-wait-for-subprocess' in test/lisp/eshell/eshell-tests-helpers.el to use the new defsubst, which would have caused it to get recompiled. (Though manually recompiling it should also work.)
I've attached a fixed patch (the first one is the same; I only updated the second).
0001-Ensure-that-tailproc-is-set-for-the-last-process-in-.patch
Description: Text document
0002-When-executing-an-Eshell-pipeline-send-input-to-the-.patch
Description: Text document
[Prev in Thread] | Current Thread | [Next in Thread] |