bug#54098: 29.0.50; Unexec build broken

[Alan Mackenzie]

Hello, Po.

On Thu, Feb 24, 2022 at 08:19:55 +0800, Po Lu wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > I've changed approach.  The previous code was continually overwriting
> > Lisp objects with themselves, particularly where it didn't need doing.
> > This is surely (??) what was happening in the pure storage.
> >
> > I've rewritten byte-run-strip-symbol-positions, so that changes are only
> > attempted where they're needed, i.e. where a symbol with position gets
> > replaced by its bare symbol.
> >
> > I'm hoping that this will now work OK, though I don't have a setup using
> > unexec to test it with.  Would you please test it.
> >
> > I'm tending to the view that we need to make this function available to
> > Lisp hackers.  I think we need both varieties of the function (the one
> > that makes a copy, and the one that modifies in situ), and that they
> > should be called simply strip-symbol-positions and
> > n-strip-symbol-positions (like reverse and nreverse).
> >
> > Anyhow, here's the patch:

> Bootstrapping an unexec build works now with your patch.  Thanks.

I've committed the patch to master, and I'm closing the bug with this
post.

-- 
Alan Mackenzie (Nuremberg, Germany).