[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy doe
From: |
Po Lu |
Subject: |
bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring |
Date: |
Mon, 28 Feb 2022 21:48:23 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Ignacio Casso <ignaciocasso@hotmail.com> writes:
> Here I have not replaced the variable, since I have assumed that code
> under the obsolete/ directory does not need to be maintained, and C-h
> f tells me that function is not loaded by default. However there is a
> warning when compiling. Should I fix it?
I can do that instead, but see below.
> - Using new variables gui--last-clipboard-selection-fingerprint and
> gui--last-primary-selection-fingerprint instead of
> gui--last-selected-text-clipboard and
> gui--last-selected-text-primary. They have the same purpose but hold
> the text and the timestamp instead of just the text, and I have
> updated the code everywhere they were referenced to use the
> text-timestamp pair instead of just the text . Better ideas for the
> names are welcome.
Can't you put a `timestamp' text property on strings stored inside the
old gui--last-selected-text-clipboard variable instead?
> - Just threw the idea that a better fingerprint would include the owner
> of the selection, if timestamps are sometimes not updated precisely
> when the owner changes, as Po Lu said.
What I said is that badly behaved clients do not change the timestamp to
take into account new data becoming available for clients they already
own. The X server ensures that timestamps always increase with
selection ownership changes.
>> diff --git a/lisp/term/pc-win.el b/lisp/term/pc-win.el
>> index 327d51f275..2ae3cbd8b2 100644
>> --- a/lisp/term/pc-win.el
>> +++ b/lisp/term/pc-win.el
>> @@ -248,7 +248,7 @@ w16-selection-owner-p
>> ;; Windows clipboard.
>> (cond
>> ((not text) t)
>> - ((equal text gui--last-selected-text-clipboard) text)
>> + ((equal text (car gui--last-clipbaord-selection-fingerprint)) t)
>> (t nil)))))
>>
> - Have not tested since I don't use Windows, but it's semantically
> equivalent as before.
pc-win is for the MS-DOS port (which does work, and should be kept
working.) However, I think this modification can be avoided by storing
the timestamp as a text property, which I proposed above.
Thanks.
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, (continued)
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/11
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Po Lu, 2022/02/11
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/11
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Po Lu, 2022/02/11
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Po Lu, 2022/02/11
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/27
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Po Lu, 2022/02/27
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/28
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Eli Zaretskii, 2022/02/28
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/28
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring,
Po Lu <=
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/28
- Message not available
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/28
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Po Lu, 2022/02/28
- Message not available
- Message not available
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/28
- Message not available
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/11
- Message not available
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Ignacio Casso, 2022/02/10
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Lars Ingebrigtsen, 2022/02/11
- bug#53894: 27.2; Clipboard copy -> C-y -> M-y -> Same clipboard copy does not push to kill ring, Eli Zaretskii, 2022/02/11