[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Esh
From: |
Jim Porter |
Subject: |
bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes |
Date: |
Thu, 3 Mar 2022 21:55:41 -0800 |
On 3/1/2022 5:10 AM, Eli Zaretskii wrote:
Thanks, installed on the emacs-28 branch. (But the markup in the
manual part was wrong; see my followup changes.)
Thanks for fixing that up.
Fine with me. It's up to you whether to close this bug or leave it
open until a better solution is found for master.
After a bit of looking at the `eshell-do-eval' implementation, I
realized that there's a better solution that's very simple. See the
attached patch. It's simple enough that it might be fine for Emacs 28,
but the existing change on the 28 branch is probably a bit safer, since
that change was just a partial revert. I'm not aware of anything that
could be broken by this new patch, but you never know...
This doesn't do anything more elaborate like using generator.el's
machinery here; while (I think) that would be nice to have eventually,
we can address that in a separate bug, since it'd be a pretty big
change. We could probably close this bug after this new patch merges.
0001-Fix-Eshell-s-command-forms-in-a-better-way.patch
Description: Text document