[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54406: 28.0.91; rcirc text wrapping
From: |
Philip Kaludercic |
Subject: |
bug#54406: 28.0.91; rcirc text wrapping |
Date: |
Thu, 17 Mar 2022 11:33:16 +0000 |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Ken Raeburn <raeburn@redhat.com> writes:
>
>> The old version in 27.1 did:
>>
>> ;; squeeze spaces out of text before rcirc-text
>> (fill-region fill-start
>> (1- (or (next-single-property-change fill-start
>> 'rcirc-text)
>> rcirc-prompt-end-marker)))
>>
>> where fill-start is set to
>>
>> (marker-position rcirc-prompt-start-marker)
>>
>> evaluated before inserting the new text. The new version seems to be
>> filling the entire narrowed region containing the just-inserted text.
>
> So I guess this was changed in:
>
> commit 849e71fd83fa8796198035464897bf2f28f6226c
> Author: Philip Kaludercic <philipk@posteo.net>
> AuthorDate: Wed Jun 9 17:55:55 2021 +0200
>
> I've added Philip to the CCs; perhaps he has some comments.
It seems this was just a misunderstanding on what the "squeeze"-code
does. The reason it had to be changed is so that messages with
time-stamps could be received out-of-order. I am guessing (but would
have to look into it in more detail) that the intention could be
implemented more elegantly than by calling fill-region on a specific
region.
--
Philip Kaludercic