bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#54359: 29.0.50; [PATCH] Undo breaking change to project interface


From: Dmitry Gutov
Subject: bug#54359: 29.0.50; [PATCH] Undo breaking change to project interface
Date: Fri, 18 Mar 2022 02:56:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 17.03.2022 13:28, Lars Ingebrigtsen wrote:
Rudolf Adamkovič<salutis@me.com>  writes:

I did not post the patch, but I too noticed the breakage when I could
not open a project at work out of sudden.  I had to change my
configuration file as follows:

  (defun my/project-try-local (dir)
    "Find projects marked with a '.project' stamp file."
    (let ((project-dir (locate-dominating-file dir ".project")))
-    (if project-dir (cons 'vc project-dir) nil)))
+    (if project-dir `(vc Git ,project-dir) nil)))
Right.  Then I think Dick's patch seems like the right solution here,
but I'm largely unfamiliar with project.el.  Dmitry?

Of course not.

And my/project-try-local shouldn't reuse the data type belonging to the vc project type either.

If it used its own type tag and generic method implementations, it wouldn't see this kind of breakage.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]