bug#54532: [PATCH] sorting

[Andrew Cohen]

>>>>> "EZ" == Eli Zaretskii <eliz@gnu.org> writes:

    >> From: Andrew Cohen <acohen@ust.hk> Date: Wed, 23 Mar 2022
    >> 07:59:11 +0800
    >> 
    >> The patch has 4 parts:

[...]

    EZ> Thanks, a few minor stylistic issues:


[...]

    EZ> Please fix your commentary that documents functions with the
    EZ> above rules in mind.

Will do.

    >> +static ptrdiff_t +count_run (merge_state *ms, Lisp_Object *lo,
    >> const Lisp_Object *hi, bool *descending)

    EZ> This line is too long, please break it in two.

Yes.

    >> + eassume (lastofs == ofs); /* Then a[ofs-1] < key <= a[ofs].  */
    >> + return ofs; +}

    EZ> Is this really eassume, or is eassert better here?

See the comment by Mattias (this is outside my area of expertise).

-- 
Andrew Cohen