[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54931: [PATCH] Have submit-emacs-patch prompt for patch file before
From: |
Philip Kaludercic |
Subject: |
bug#54931: [PATCH] Have submit-emacs-patch prompt for patch file before subject |
Date: |
Thu, 14 Apr 2022 16:41:08 +0000 |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> When sending patches using submit-emacs-patch, I usually want to reuse
>> the commit title for the message subject. As a minor convenience, this
>> can be guessed when the patch file is prompted before the subject,
>> allowing for a default value to be provided by extracting the "Subject"
>> header from the patch file.
>
> Looks good to me, please go ahead and push.
Done,
>> + (list (read-string (format-prompt "This patch is about" guess )
>> + nil nil guess)
>
> But without that space between "guess" and ")".
done,
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Reading through time_cmp, I didn't understand why the lisp_time struct
>> was calculated for the first argument before checking if both are eq.
>>>From what I see lisp_time struct is not a destructive function, so it
>> should be possible to call the function when calculating the lisp_time
>> struct for the second argument.
>
> Looks good to me; please go ahead and push.
and done.
--
Philip Kaludercic