[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time brok
From: |
Eli Zaretskii |
Subject: |
bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode |
Date: |
Thu, 28 Apr 2022 16:38:47 +0300 |
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 55163@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>, Eli Zaretskii
> <eliz@gnu.org>
> Date: Thu, 28 Apr 2022 14:10:57 +0200
>
> Vincenzo Pupillo <v.pupillo@gmail.com> writes:
>
> > the recent patch 4a1f69ebca broke the lsp-mode logging code. The logging
> > code uses the expression
> > expression (/ (nth 2 (time-since before-send)) 1000) to
> > calculate the time of the event to be logged. lsp-mode starts the
> > lsp-server, but is unable to work.
>
> Paul, it seems like this change is just breaking too much code out
> there, so I think it'll have to be reverted.
>
> Eli, what do you think?
I tend to agree.
I actually didn't expect Paul to make such changes, given the recent
discussion on emacs-devel, where he seemed to agree with my argument
against this kind of changes. But he did make this change regardless.
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Vincenzo Pupillo, 2022/04/28
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Lars Ingebrigtsen, 2022/04/28
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode,
Eli Zaretskii <=
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Paul Eggert, 2022/04/28
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Lars Ingebrigtsen, 2022/04/28
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Lars Ingebrigtsen, 2022/04/29
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Eli Zaretskii, 2022/04/29
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Lars Ingebrigtsen, 2022/04/29
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Eli Zaretskii, 2022/04/29
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Paul Eggert, 2022/04/29
- bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode, Eli Zaretskii, 2022/04/29