bug#55205: 28.1.50; completion--replace illegally mutates completion candidates

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> But I still have no idea why we're stripping text properties in the
>> first place, so could you please explain that?
>
> It depends where.  In `completion--replace` it's explained in the
> comment:
>
>     ;; The properties on `newtext' include things like the
>     ;; `completions-first-difference' face, which we don't want to
>     ;; include upon insertion.

So it's really about stripping modifications that completion has already
done to the strings?  Well, that seems like an easy enough problem to
deal with -- just remove those, and leave the rest of the text
properties alone.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no