bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#55169: Can't combine window-min-height with window-height


From: martin rudalics
Subject: bug#55169: Can't combine window-min-height with window-height
Date: Fri, 6 May 2022 09:02:51 +0200

> Do you think it would be simpler and thus more reliable
> to enforce height constraints such as min-height
> in fit-window-to-buffer?
>
> This will be very clear to users to see how it works:
>
>    (pop-to-buffer (generate-new-buffer "*edit string*")
>                   '(display-buffer-below-selected
>                     (window-height (fit-window-to-buffer 10))))
>
> where 10 is min-height.
>
> Because it should be the task of fit-window-to-buffer,
> and it already has the argument MIN-HEIGHT.
> Also other arguments of fit-window-to-buffer
> could be allowed to use in display-buffer-alist.

You mean the value of a 'window-height' entry could also be a

        • A list whose CAR is a function and whose remaining elements
          are the arguments passed to that function.

so we'd run

            (ignore-errors (funcall (car height) window (nth 1 height) ...))

in 'window--display-buffer'?  Which means the caller has to know the
function and which arguments it needs in which order.  Sounds fragile.

martin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]