bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#55370: [PATCH] Add support for the Syloti Nagri script


From: समीर सिंह Sameer Singh
Subject: bug#55370: [PATCH] Add support for the Syloti Nagri script
Date: Sun, 15 May 2022 05:17:07 +0530

I have updated the patch.

1. Wherever the nasal signs are not in range, I have not included them in a composition rule if they appear alone with a character and left them up to composite.el.
For eg in Kaithi

- ;; Nasal vowels
- (concat independent-vowel nasal "?")
+ ;; Vowel based syllables
+ (concat independent-vowel nukta "?" virama "?" vowel "?")

2. I have also written composition rules for independent vowels with nukta, virama, vowel signs etc, so that Emacs does not hang when they are typed together.

Please review the patch.

On Thu, May 12, 2022 at 10:58 PM समीर सिंह Sameer Singh <lumarzeli30@gmail.com> wrote:
Ok I will do that, thanks!

On Thu, May 12, 2022 at 10:55 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Thu, 12 May 2022 22:40:02 +0530
> Cc: 55370@debbugs.gnu.org
>
> Yes it was not correct, this seems more appropriate.
>
> ;; Syloti Nagri composition rules
> (let ((consonant            "[\xA807-\xA80A\xA80C-\xA822]")
>       (independent-vowel    "[\xA800\xA801\xA803-\xA805]")
>       (vowel                "[\xA802\xA823-\xA827]")
>       (nasal                "[\xA80B]")
>       (virama               "[\xA806\xA82C]"))
>   (set-char-table-range composition-function-table
>                         '(#xA802 . #xA82C)
>                         (list (vector
>                                ;; Consonant conjunct based syllables
>                                (concat independent-vowel "?" consonant "\\(?:" virama consonant "\\)+"
>                                        vowel "?" nasal "?")
>                                1 'font-shape-gstring))))
>
> btw this range does not cause emacs to slow down, right?

It might, because the range is very large, and so any character in the
range #xA802..#xA82C will cause Emacs to try to match the regexp.

So if there's a way of having the rules on fewer characters, that
would be better, even if there will be more rules.

> also should I send separate patches for the syloti nagri, and the fix for previous scripts, or combine them into
> one?

You can combine them into a single patch, just make sure the log
message mentions all the changes.

Thanks.

Attachment: 0001-Add-support-for-the-Syloti-Nagri-script.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]