bug#32921: emacsclient obeys Xresources even when launched with -nw

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Which sequence of calls ends up calling x-handle-reverse-video, and
> what is the trigger for that sequence of calls?

It's:

Debugger entered: nil
  x-handle-reverse-video(#<frame GNU Emacs at xo 0x55a6e4722360> 
((vertical-scroll-bars) (height . 53) (width . 81) (reverse . t) (cursor-color 
. "red") (cursor-type . box) (mouse-color . "red") (horizontal-scroll-bars)))
  x-create-frame-with-faces(((vertical-scroll-bars) (height . 53) (width . 81) 
(reverse . t) (cursor-color . "red") (cursor-type . box) (mouse-color . "red") 
(horizontal-scroll-bars)))
  #f(compiled-function (params) #<bytecode 
-0x1d5f77f46341f751>)(((vertical-scroll-bars) (height . 53) (width . 81) 
(reverse . t) (cursor-color . "red") (cursor-type . box) (mouse-color . "red") 
(horizontal-scroll-bars)))
  apply(#f(compiled-function (params) #<bytecode -0x1d5f77f46341f751>) 
((vertical-scroll-bars) (height . 53) (width . 81) (reverse . t) (cursor-color 
. "red") (cursor-type . box) (mouse-color . "red") (horizontal-scroll-bars)))
  frame-creation-function(((vertical-scroll-bars) (height . 53) (width . 81) 
(reverse . t) (cursor-color . "red") (cursor-type . box) (mouse-color . "red") 
(horizontal-scroll-bars)))
  make-frame()

> (These kinds of changes in code that was there for decades give me the
> creeps.)

Indeed.  I tried to do some VC history spelunking for why we're
apparently checking reverseVideo redundantly in this way, but I came up
short.

It might not be redundant on Windows, which presumably doesn't call
these X functions, but does heed reverseVideo in the w32 version of
window-system-initialization.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no