bug#55590: [PATCH] 29.0.50; Eshell subcommands clobber pipelines and produce incorrect output

[Sean Whitton]

Hello Jim,

On Sun 22 May 2022 at 08:43pm -07, Jim Porter wrote:

> On 5/22/2022 8:34 PM, Jim Porter wrote:
>> Starting from `emacs -Q -f eshell', enter the following command:
>>
>>    echo ${*echo hi} | rev
>>
>> The output is:
>>
>>    ~ $ ih
>>
>> That is, the output of the command ended up *after* the prompt, when it
>> should be before.
>
> The attached patch fixes this issue. It might not be the *best* way to
> do it, but it's the least-invasive I could come up with. The
> `make-symbol' dance is a bit awkward, but Eshell already uses it for
> `eshell-command-to-value' / `eshell-do-command-to-value', so hopefully
> it's ok.

Couldn't you just defvar a couple of vars for this purpose?

-- 
Sean Whitton