[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55068: 29.0.50; crashes when trying to set default font
From: |
Po Lu |
Subject: |
bug#55068: 29.0.50; crashes when trying to set default font |
Date: |
Mon, 23 May 2022 20:29:23 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> ==3291841== Warning: client switching stacks? SP change: 0x1ffeffdf60 -->
> 0x1ffe619240
> ==3291841== to suppress, use: --max-stackframe=10374432 or greater
> ==3291841== Warning: client switching stacks? SP change: 0x1ffe619240 -->
> 0x1ffdc34520
> ==3291841== to suppress, use: --max-stackframe=10374432 or greater
> ==3291841== Invalid write of size 8
> ==3291841== at 0x1E43BF: x_menu_show (xmenu.c:1903)
> ==3291841== Address 0x1ffdc34518 is on thread 1's stack
The stack overflowed because of the two allocas. Does it still crash
with this patch?
diff --git a/src/xmenu.c b/src/xmenu.c
index aaf53569a7..e9601981ed 100644
--- a/src/xmenu.c
+++ b/src/xmenu.c
@@ -1894,13 +1894,19 @@ x_menu_show (struct frame *f, int x, int y, int
menuflags,
{
int i;
widget_value *wv, *save_wv = 0, *first_wv = 0, *prev_wv = 0;
- widget_value **submenu_stack
- = alloca (menu_items_used * sizeof *submenu_stack);
- Lisp_Object *subprefix_stack
- = alloca (menu_items_used * sizeof *subprefix_stack);
+ widget_value **submenu_stack;
+ Lisp_Object *subprefix_stack;
int submenu_depth = 0;
+ specpdl_ref specpdl_count;
- specpdl_ref specpdl_count = SPECPDL_INDEX ();
+ USE_SAFE_ALLOCA;
+
+ submenu_stack = SAFE_ALLOCA (menu_items_used
+ * sizeof *submenu_stack);
+ subprefix_stack = SAFE_ALLOCA (menu_items_used
+ * sizeof *subprefix_stack);
+
+ specpdl_count = SPECPDL_INDEX ();
eassert (FRAME_X_P (f));
@@ -1909,6 +1915,7 @@ x_menu_show (struct frame *f, int x, int y, int menuflags,
if (menu_items_used <= MENU_ITEMS_PANE_LENGTH)
{
*error_name = "Empty menu";
+ SAFE_FREE ();
return Qnil;
}
@@ -2141,6 +2148,8 @@ x_menu_show (struct frame *f, int x, int y, int menuflags,
entry = Fcons (subprefix_stack[j], entry);
}
unblock_input ();
+
+ SAFE_FREE ();
return entry;
}
i += MENU_ITEMS_ITEM_LENGTH;
@@ -2155,6 +2164,8 @@ x_menu_show (struct frame *f, int x, int y, int menuflags,
}
unblock_input ();
+
+ SAFE_FREE ();
return Qnil;
}
- bug#55068: 29.0.50; crashes when trying to set default font, Lars Ingebrigtsen, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Gregor Zattler, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Lars Ingebrigtsen, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Eli Zaretskii, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Lars Ingebrigtsen, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Po Lu, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Lars Ingebrigtsen, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Lars Ingebrigtsen, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font,
Po Lu <=
- bug#55068: 29.0.50; crashes when trying to set default font, Lars Ingebrigtsen, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Po Lu, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Eli Zaretskii, 2022/05/23
- bug#55068: 29.0.50; crashes when trying to set default font, Po Lu, 2022/05/23