bug#55651: 28.1; Wrong format specifiers in tramp-adb-get-device

[Michael Albinus]

Version: 28.2

Hayden Shenk <hayden.shenk@zetier.com> writes:

Hi Hayden,

> Description:
> When attempting to open a file on Android devices via tramp using adb
> over tcp/ip tramp-adb-get-device throws the following error:
>
> error: "Format specifier doesn’t match argument typex"

Thanks for reporting!

> Reproducing the bug:
> To reproduce the bug set up an android device to connect to over
> TCP/IP with adb.  Instructions to do so can be found here:
>
> https://developer.android.com/studio/command-line/adb
>
> In this example, we'll assume the device is listening for adb
> connections on 192.168.1.7:7449
>
> Then the bug can be triggered by executing the following bit of elisp:
>
> (find-file "/adb:192.168.1.7#7449:/data/local/tmp")
>
> Patch:
> Here is a proposed patch, which fixes the issue on my host:

Yep. tramp-dissect-file-name returns the port as a string for a long
time already, it was an oversight that this hasn't been changed
here. I've applied the patch in your name to the repositories, will
appear with Emacs 28.2.

Tramp 2.5.2.5, which will be released next days on GNU ELPA, will
contain the patch as well. Closing the bug.

Best regards, Michael.