bug#55684: 29.0.50; wrong-type-argument in minibuffer-only frames

[Alan Mackenzie]

Hello, Eli.

On Sat, May 28, 2022 at 08:56:04 +0300, Eli Zaretskii wrote:
> > Cc: Alan Mackenzie <acm@muc.de>
> > Date: Fri, 27 May 2022 16:09:13 -0400
> > From:  Stefan Monnier via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>

> > Package: Emacs
> > Version: 29.0.50

> Doesn't the same problem exist on the emacs-28 branch?  I can
> reproduce it there.

> > -    Fset_frame_selected_window (frame, call1 (Qget_mru_window, frame), 
> > Qnil);
> > +    {
> > +      Lisp_Object w = call1 (Qget_mru_window, frame);
> > +      if (!NILP (w))            /* Can be nil in minibuffer-only frames.  
> > */
> > +        Fset_frame_selected_window (frame, w, Qnil);

> The NILP(w) test should probably be WINDOW_LIVE_P(w).  Martin, do you
> agree?

I'm not Martin, but I think WINDOW_LIVE is safe, but might not be
needed.  I think get-mru-window will only return a live window or nil.

-- 
Alan Mackenzie (Nuremberg, Germany).