bug#55687: 29.0.50; make-frame chid frame crash/regression from dfa3e6f424

[Aaron Jensen]

On Sun, May 29, 2022 at 1:36 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Aaron Jensen <aaronjensen@gmail.com>
> > Date: Sat, 28 May 2022 16:11:03 -0400
> > Cc: 55687@debbugs.gnu.org, acm@muc.de
> >
> > On Sat, May 28, 2022 at 2:29 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > >
> > > The patch Stefan posted earlier in bug#55684 fixes this problem as
> > > well, AFAICT.
> >
> > I can confirm that this fixes one of the issues I reported, but not this 
> > one:
> >
> > (make-frame `((parent-frame . ,(selected-frame))))
> >
> > I don't know if there's something else invalid about this, but it
> > crashes Emacs, at least on macOS.
>
> Is this in "emacs -Q"?  It doesn't crash for me here, neither with
> today's master nor with the emacs-28 branch.  So maybe it is
> macOS-specific, or some customizations are needed to trigger it.

Yes, it is with "emacs -Q".

> > -[EmacsWindow setFrame:display:animate:] + 40
> >         23  AppKit                              0x00000001a0fe14cc
> > -[NSThemeFrame 
> > _growWindowReshapeContentAndToolbarView:withOldToolbarFrameSize:animate:]
> > + 1232
> >         24  AppKit                              0x00000001a0fe0ddc
> > -[NSThemeFrame 
> > _reshapeContentAndToolbarView:withOldToolbarFrameSize:resizeWindow:animate:]
> > + 300
> >         25  AppKit                              0x00000001a0fc16b0
> > -[NSThemeFrame _showHideToolbar:resizeWindow:animate:] + 284
> >         26  AppKit                              0x00000001a0fb06c0
> > -[NSWindow _showToolbar:animate:] + 216
> >         27  AppKit                              0x00000001a0fb05c0
> > -[NSToolbar _show:animate:] + 48
> >         28  AppKit                              0x00000001a0fae054
> > -[NSWindow setToolbar:] + 644
> >         29  Emacs                               0x00000001004551c0
> > -[EmacsWindow createToolbar:] + 168
> >         30  Emacs                               0x00000001004550c4
> > -[EmacsWindow initWithEmacsFrame:fullscreen:screen:] + 1868
> >         31  Emacs                               0x0000000100452650
> > -[EmacsView initFrameFromEmacs:] + 464
> >         32  Emacs                               0x0000000100460858
> > Fx_create_frame + 4388
> >         33  faces-b9447c93-57cd3aa1.eln         0x000000010487e7e0
> > F782d6372656174652d6672616d652d776974682d6661636573_x_create_frame_with_faces_0
> > + 304
>
> This part seems to say that it crashes while working on the tool bar.

Interesting. Luckily, I have never run across this other then while
trying to repro the first bug I reported here. Alan, any ideas? Does
this crash for you?

Aaron