[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55849: 29.0.50; process-async-https-with-delay error detection is wr
From: |
Eli Zaretskii |
Subject: |
bug#55849: 29.0.50; process-async-https-with-delay error detection is wrong |
Date: |
Wed, 08 Jun 2022 19:52:51 +0300 |
> Date: Wed, 8 Jun 2022 12:30:31 -0400
> From: Ken Brown <kbrown@cornell.edu>
>
> diff --git a/test/src/process-tests.el b/test/src/process-tests.el
> index f5908d3cda..824c6da119 100644
> --- a/test/src/process-tests.el
> +++ b/test/src/process-tests.el
> @@ -931,7 +931,7 @@ process-async-https-with-delay
> (< (float-time) (+ t0 limit)))
> (sit-for 0.1)))
> (should status)
> - (should-not (assq :error status))
> + (should-not (plist-get status ':error))
> (should buf)
> (should (> (buffer-size buf) 0))
> )
>
> With this patch the correct reason for the failure is shown:
>
> Test process-async-https-with-delay condition:
> (ert-test-failed
> ((should-not
> (plist-get status ':error))
> :form
> (plist-get
> (:error
> (error connection-failed "deleted\n" :host "elpa.gnu.org" :service
> 443))
> :error)
> :value
> (error connection-failed "deleted\n" :host "elpa.gnu.org" :service
> 443)))
>
> OK to apply?
Yes, please.
> If so, to which branch? The problem exists on both master
> and the release branch.
Please install on the release branch, and thanks.