bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#55696: 28.1; eshell fails to respect text-scale-increase


From: Eli Zaretskii
Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase
Date: Fri, 10 Jun 2022 08:52:45 +0300

> Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Thu, 9 Jun 2022 15:14:22 -0700
> 
> > If I make this replacement in 4 tests that use "list", then it doesn't
> > hang, but 2 tests fail:
> 
> That makes sense. Those other tests that are now failing should stay 
> unchanged. The difference is in the brace style of the commands.
> 
> For `esh-var-test/interp-lisp-indices': the expansion is '$(list 1 2)', 
> which means "evaluate '(list 1 2)' as a Lisp sexpr". This doesn't need 
> to change.
> 
> For `esh-var-test/interp-cmd-indices': the expansion is '${list 1 2}',
> which means "evaluate 'list 1 2' as a shell-like command". In this case, 
> if there's an external program named 'list', it will call that; 
> otherwise, it will call the Lisp function `list'. (If there were a Lisp 
> function named `eshell/list', Eshell would always prefer that.) Here, we 
> should use 'listify', since it's the preferred Eshell way to make a list 
> using command-style syntax.

What if there's an external command named 'listify' -- is there any
chance that the test will invoke it?  If so, I think we should come up
with a safer solution.

Otherwise, feel free to install the change, and thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]