bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message

[Visuwesh]

[புதன் ஜூன் 15, 2022 10:25] Juri Linkov wrote:

> close 55977 29.0.50
> thanks
>
>>>>> repeat-mode echoes unset keys in the help message since it doesn't check
>>>>> for non-nil value of command bound to key; will attach patch once I get
>>>>> the bug number.
>>>>
>>>> Thanks, but can you please show a recipe from "emacs -Q", to
>>>> understand better what problem are you trying to fix?
>>>
>>> Sure.
>>>
>>>     1. M-x repeat-mode RET.
>>>     2. C-h n.
>>>     3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
>>>     4. C-c @ C-n.  Notice how the help message still says C-n despite
>>>        being unbound, and when you type C-n the repeat map exits
>>>        contrary to what the message says.
>>
>> Oh, looks like if I give `define-key' a non-nil REMOVE argument, then
>> C-n is no longer displayed in the help message.
>
> Indeed, the REMOVE removes a key, but nil is also a valid way to undefine a 
> key,
> so now your patch is pushed to master, thanks.

Great, thanks!