[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56198: Request to delete window with mouse event
From: |
Visuwesh |
Subject: |
bug#56198: Request to delete window with mouse event |
Date: |
Sat, 25 Jun 2022 19:44:05 +0530 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
[சனி ஜூன் 25, 2022] carlmarcos--- via "Bug reports for GNU Emacs, the Swiss
army knife of text editors" wrote:
> Jun 25, 2022, 08:24 by eliz@gnu.org:
>
>>> Cc: 56198@debbugs.gnu.org
>>> Date: Sat, 25 Jun 2022 09:35:21 +0200 (CEST)
>>> From: carlmarcos--- via "Bug reports for GNU Emacs,
>>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>>
>>> Actually, I have noticed a problem with using mouse-3 on mode-line. Suppose
>>> you push mouse-3 on mode-line, the window is removed without giving me the
>>> possibility to net remove it should I change my mind.
>>>
>>
>> Why is that a problem? Removing a window doesn't lose any important
>> information, and you can easily restore it with "C-x 4 b" or somesuch.
>>
> If would be neater to activate only when the mouse-3 button release occurs on
> the mode-line
> or window. If one moves the mouse pointer outside the window or outside
> emacs, then releasing
> the pressed mouse-3 button, would have no effect. This would be consistent
> with how menus work.
Ah indeed, that would be nice. The following patch does the job for me
but maybe there's a cleaner way to do this?
diff --git a/lisp/mouse.el b/lisp/mouse.el
index 82c8a14693..1878709113 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -655,7 +655,9 @@ mouse-delete-window
(interactive "e")
(unless (one-window-p t)
(mouse-minibuffer-check click)
- (delete-window (posn-window (event-start click)))))
+ (when (eq (posn-window (event-end click))
+ (posn-window (event-start click)))
+ (delete-window (posn-window (event-start click))))))
(defun mouse-select-window (click)
"Select the window clicked on; don't move point."
The same should done for mouse-2 as well.
- bug#56198: Request to delete window with mouse event, carlmarcos, 2022/06/24
- bug#56198: Request to delete window with mouse event, Juri Linkov, 2022/06/24
- bug#56198: Request to delete window with mouse event, Visuwesh, 2022/06/24
- Message not available
- bug#56198: Request to delete window with mouse event, carlmarcos, 2022/06/25
- bug#56198: Request to delete window with mouse event, Visuwesh, 2022/06/25
- bug#56198: Request to delete window with mouse event, Eli Zaretskii, 2022/06/25
- bug#56198: Request to delete window with mouse event, carlmarcos, 2022/06/25
- bug#56198: Request to delete window with mouse event,
Visuwesh <=
- bug#56198: Request to delete window with mouse event, Lars Ingebrigtsen, 2022/06/26
- bug#56198: Request to delete window with mouse event, Visuwesh, 2022/06/26
- bug#56198: Request to delete window with mouse event, Lars Ingebrigtsen, 2022/06/26
- bug#56198: Request to delete window with mouse event, Visuwesh, 2022/06/26
- bug#56198: Request to delete window with mouse event, Lars Ingebrigtsen, 2022/06/26
- Message not available
- bug#56198: Request to delete window with mouse event, carlmarcos, 2022/06/26
- bug#56198: Request to delete window with mouse event, Eli Zaretskii, 2022/06/26
bug#56198: Request to delete window with mouse event, Tak Kunihiro, 2022/06/28
Message not available