bug#57691: 29.0.50; image-tests failures

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> Running test/manual/image-tests.el, as in
>
>   ./src/emacs -Q -l test/manual/image-tests.el --eval "(ert t)"
>
> produces 2 failures:

Thanks for reporting this.

> F image-tests-image-metadata/gif
>     (ert-test-failed
>      ((should
>        (memq 'delay
>             (image-metadata
>              (create-image ...))))
>       :form
>       (memq delay nil)
>       :value nil))

That doesn't happen here, so maybe it's MS-Windows specific?

Could you build with --enable-checking="glyphs", and see what you get
from evaluating:

  (let ((img (create-image
              (expand-file-name "test/data/image/black.gif"
                                source-directory))))
    (cons (lookup-image img) (image-metadata img)))

It should print some output to the terminal too, which is also
interesting.

For reference, I get:

  (10 delay 0.06666666666666667 extension-data (249 "\^A\0\0\^A"))

Note that the above 1/15=0.066 delay is what we expect (see
image.c:9452).  I also get this terminal output:

  (image :type gif :file
  "/home/skangas/wip/emacs/test/data/image/black.gif"
  :scale 1.0031746031746032 :transform-smoothing t)

I'm not sure if it matters or not, but do you happen to know which
version of giflib you're using?

> F image-tests-load-image/svg-invalid
>     (ert-test-failed
>      ((should
>        (string-search "XML parse error"
>                     (buffer-string)))
>       :form
>       (string-search "XML parse error" "For information about GNU Emacs and 
> the GNU system, type C-h C-a.\nType C-c C-c to view the image as text\nError 
> parsing SVG image: Error domain 1 code 4 on line 1 column 1 of data: Start 
> tag expected, '<' not found [3 times]\n")
>       :value nil))

This looks like some version of librsvg giving a different error
message.  Does the attached patch fix this for you?

Also, out of interest, do you know which version of librsvg you're
using?

0001-Fix-SVG-test-for-old-librsvg.patch
Description: Text Data