[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#57813: Icon images are non-functional
From: |
Eli Zaretskii |
Subject: |
bug#57813: Icon images are non-functional |
Date: |
Mon, 19 Sep 2022 15:12:25 +0300 |
> From: Juri Linkov <juri@linkov.net>
> Cc: 57813@debbugs.gnu.org
> Date: Sun, 18 Sep 2022 22:06:56 +0300
>
> > Thanks. I only quickly read the patch, and have one comment: the
> > hard-coded left-margin should depend on the value returned by
> > current-bidi-paragraph-direction, because text that is displayed
> > right-to-left should have the icons on the right margin, not left
> > margin.
>
> To not create a new mirrored image file for RTL arrow required a change in
> icons--create to support ':rotation 180' for the existing image file:
>
> (define-icon outline-close-rtl-in-margins outline-close
> '((image "outline-close.svg" "outline-close.pbm"
> :height 10 :ascent center :rotation 180))
> "Icon used for buttons for closing a section in outline buffers."
> :version "29.1"
> :help-echo "Close this section")
>
> Then the right margin could be used with:
Thanks, the code LGTM.
- bug#57813: Icon images are non-functional, (continued)
bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/15
- bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/16
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/16
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/17
- bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/18
- bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/18
bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/18
bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/18
bug#57813: Icon images are non-functional,
Eli Zaretskii <=
bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/19
bug#57813: Icon images are non-functional, Eli Zaretskii, 2022/09/20
bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/20
bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/23
bug#57813: Icon images are non-functional, Lars Ingebrigtsen, 2022/09/23
bug#57813: Icon images are non-functional, Juri Linkov, 2022/09/24