[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face
From: |
Protesilaos Stavrou |
Subject: |
bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face |
Date: |
Mon, 26 Sep 2022 17:06:22 +0300 |
User-agent: |
Notmuch/0.37 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 26 Sep 2022 16:28:56 +0300
>
> Hi!
>
> On 26.09.2022 15:44, Protesilaos Stavrou wrote:
>> Dear maintainers,
>>
>> The attached patch replaces some hardcoded face properties in log-edit
>> buffers with a named face.
>>
>> The named face allows users/themes to customise how this line is styled.
>>
>> What do you think?
>
> LGTM, except perhaps call it headers-separator? It's used to separate
> all the headers, not just summary.
Hello everyone,
I made the changes as you suggested and pushed them as commit
a386833503. However, I forgot to update the commit message of the
patch: it still mentions the old name of the face
'log-edit-summary-separator' instead of 'log-edit-headers-separator'.
Sorry for this mistake! Can I revert or amend it?
--
Protesilaos Stavrou
https://protesilaos.com
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Protesilaos Stavrou, 2022/09/26
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Lars Ingebrigtsen, 2022/09/26
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Stefan Kangas, 2022/09/26
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Dmitry Gutov, 2022/09/26
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face,
Protesilaos Stavrou <=
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Dmitry Gutov, 2022/09/26
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Robert Pluim, 2022/09/26
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Stefan Kangas, 2022/09/26
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Protesilaos Stavrou, 2022/09/26
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Sean Whitton, 2022/09/27
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Stefan Kangas, 2022/09/27
- bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face, Sean Whitton, 2022/09/27