[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58168: string-lessp glitches and inconsistencies
From: |
Mattias Engdegård |
Subject: |
bug#58168: string-lessp glitches and inconsistencies |
Date: |
Fri, 7 Oct 2022 16:45:57 +0200 |
6 okt. 2022 kl. 16.34 skrev Eli Zaretskii <eliz@gnu.org>:
> I don't think it matters much, because whatever we produce we cannot
> be sure it will look identical to the original format string.
I agree. What about this patch then?
format-error.diff
Description: Binary data
Not very important, but at least it should be a (minor) improvement.
> A test suite doesn't have to
> assume that the internals work as they should, it should just test
> that. So testing both sounds to me better than testing just one
> assuming that this one covers both.
I agree, we should definitely test raw bytes inserted from both unibyte and
multibyte strings. The current code doesn't do that, hence my patch.
With respect to other values there should be a reasonable qualitative
difference between test cases: testing both #x80 and #xfc isn't more useful
than testing the display of both the letters 'A' and 'B'. But if you think that
the current code is deficient in coverage, please do propose extensions and
I'll adapt the patch accordingly.
- bug#58168: string-lessp glitches and inconsistencies, (continued)
- bug#58168: string-lessp glitches and inconsistencies, Lars Ingebrigtsen, 2022/10/01
- bug#58168: string-lessp glitches and inconsistencies, Mattias Engdegård, 2022/10/03
- bug#58168: string-lessp glitches and inconsistencies, Lars Ingebrigtsen, 2022/10/04
- bug#58168: string-lessp glitches and inconsistencies, Eli Zaretskii, 2022/10/04
- bug#58168: string-lessp glitches and inconsistencies, Mattias Engdegård, 2022/10/04
- bug#58168: string-lessp glitches and inconsistencies, Eli Zaretskii, 2022/10/04
- bug#58168: string-lessp glitches and inconsistencies, Mattias Engdegård, 2022/10/06
- bug#58168: string-lessp glitches and inconsistencies, Eli Zaretskii, 2022/10/06
- bug#58168: string-lessp glitches and inconsistencies, Mattias Engdegård, 2022/10/06
- bug#58168: string-lessp glitches and inconsistencies, Eli Zaretskii, 2022/10/06
- bug#58168: string-lessp glitches and inconsistencies,
Mattias Engdegård <=
- bug#58168: string-lessp glitches and inconsistencies, Eli Zaretskii, 2022/10/07
- bug#58168: string-lessp glitches and inconsistencies, Mattias Engdegård, 2022/10/08
- bug#58168: string-lessp glitches and inconsistencies, Eli Zaretskii, 2022/10/01