|
From: | Jim Porter |
Subject: | bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients |
Date: | Mon, 10 Oct 2022 10:49:05 -0700 |
On 10/10/2022 9:59 AM, Eli Zaretskii wrote:
Date: Mon, 10 Oct 2022 09:43:55 -0700 Cc: 58404@debbugs.gnu.org From: Jim Porter <jporterbugs@gmail.com> Here's why I think prompting then makes sense: when you're in an emacsclient frame and there are other non-client frames (i.e. ones "owned" by the main Emacs process), that looks very similar to the user as when you have a second emacsclient running.No, there's a very fundamental difference between the two. When there are client frames showing buffers, for each client buffer there's a process waiting, the process which requested the buffer to be edited. That's why we prompt: we don't want to fail those waiting processes. Non-client frames don't have this problem.
Ok, I think that makes sense. I was hesitant about removing prompts too aggressively, since I didn't want to open users up to losing some Emacs state without prompting when they would have gotten a prompt before. However, you've convinced me that we don't need to worry about non-client frames since they don't have processes waiting on them. (Maybe some users would want more prompts in case they accidentally kill Emacs, but they can always add to 'kill-emacs-query-functions'.)
Attached is a new patch that removes the prompt when called from the last remaining client. I also expanded the docstring to explain why the prompt is there.
0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.patch
Description: Text document
[Prev in Thread] | Current Thread | [Next in Thread] |