[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs windo
From: |
Po Lu |
Subject: |
bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window |
Date: |
Wed, 12 Oct 2022 08:47:05 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Uwe Brauer <oub@mat.ucm.es> writes:
>>>> "PL" == Po Lu <luangruo@yahoo.com> writes:
>
>> Uwe Brauer <oub@mat.ucm.es> writes:
>>> Ok, sigh, I was afraid of that, but fair enough, and currently master
>>> has some nice new exiting features I would like to test.
>
>> BTW, screwing around with the Kwin in Trinity did not result in the bug
>> for me, so it would be nice if you could bisect for that as well.
>
> I found it, *you* are the culprit 😉
>
> It is commit 136495f178cc
>
> * commit 136495f178ccd36b23ffc347fe2b6680fd689e34
> │ Author: Po Lu <luangruo@yahoo.com>
> │ Date: Wed, 31 Aug 2022 10:17:20 +0800
> │
> │ Gently nudge Xt into always setting size hints
> │
> │ * src/widget.c (update_wm_hints): Force a resource to change
> │ every time this function is called. (bug#57475)
> │ (EmacsFrameInitialize): Initialize new field.
> │ * src/widgetprv.h (EmacsFramePart): New field `size_switch'.
> │ * src/xterm.c (x_wm_set_size_hint): Don't change flags if flags
> │ is 0.
>
> That causes the problem with and without athena. So it is responsible
> for both problems.
Did you test with GTK during the bisection as well? That code only
affects the X toolkit builds.
Also, what happens if you remove the change to widget.c?
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, (continued)
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Po Lu, 2022/10/10
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Uwe Brauer, 2022/10/10
- bug#58412: [Problems also without athena] (was: bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window), Uwe Brauer, 2022/10/10
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Po Lu, 2022/10/10
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Uwe Brauer, 2022/10/11
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Po Lu, 2022/10/11
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Uwe Brauer, 2022/10/11
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Po Lu, 2022/10/11
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Uwe Brauer, 2022/10/11
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window,
Po Lu <=
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Uwe Brauer, 2022/10/12
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Po Lu, 2022/10/12
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Uwe Brauer, 2022/10/12
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Po Lu, 2022/10/12
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Uwe Brauer, 2022/10/12
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Po Lu, 2022/10/12
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Uwe Brauer, 2022/10/12
- bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window, Po Lu, 2022/10/12