bug#57556: 28.1; Eshell not finding executables in PATH when tramp-integration loaded

[Jim Porter]

On 10/9/2022 11:01 AM, Michael Albinus wrote:
> Jim Porter <jporterbugs@gmail.com> writes:
>
> > I attached an updated version of my connection-local.el that tries to
> > pull out the additions you made into some helpers. What do you think?
>
> I gave it a short reading, and in general it looks OK (comments
> below). Do you want to provide a patch for files-x.el with this?

Thanks for taking a look. I've added a separate patch (0002 in this 
series) for adding these functions (with some improvements over the 
little test script we worked on) to files-x.el. (Patch 0001 just fixes 
an issue in the docs/tests where the :application had an extra quote.)

If you think it would be easier to track, I could file a new bug and put 
patches 0001 and 0002 in there, then come back to this bug once that's 
merged. Either way is fine by me.

The other patches in this series are mostly-unchanged from before, 
except for 0006, which now uses the new 'setq-connection-local' macro.

> This patch shall also extent the "Connection Local Variables" section of
> the Elisp manual. This section is already quite
> long (~150 lines), and speaks almost about static setting of
> connection-local variables. You bring dynamic settings here, maybe a
> subsection would help to structure. And feel free to restructure the
> other, long text if you believe it would help.

I added all this to the manual (with an example), and divided the 
Connection Local Variables section into two subsections: one for how to 
initialize profiles and set criteria for them, and another for applying 
the variables. I put the 'setq-connection-local' docs in the second 
section, since it's closely related to 'with-connection-local-variables'.

> Btw, do you have write access to the Emacs git repo? If not I recommend
> to ask the maintainers (Eli or Lars) for this.

I do have commit access to the git repo now, so I'll be able to merge 
these patches on my own once they look good.

0001-Remove-over-quoting-of-application-values-in-connect.patch
Description: Text document

0002-Add-helpers-to-dynamically-assign-connection-local-v.patch
Description: Text document

0003-Allow-ignoring-errors-when-calling-eshell-match-comm.patch
Description: Text document

0004-Obsolete-eshell-define.patch
Description: Text document

0005-Allow-setting-the-values-of-variable-aliases-in-Eshe.patch
Description: Text document

0006-Improve-handling-of-PATH-in-Eshell-for-remote-direct.patch
Description: Text document

0007-Print-the-correct-PATH-when-Eshell-s-which-fails-to-.patch
Description: Text document