[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58446: 28.2; file-attribute-device-number returns a cons cell instea
From: |
Stefan Monnier |
Subject: |
bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer |
Date: |
Fri, 14 Oct 2022 14:34:09 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
>> - The name `file-attribute-file-number` doesn't sound right
>> because it doesn't return a number.
> The name is a reminiscence of the existing variable buffer-file-number,
> which serves exactly the same purpose.
One error doesn't justify another.
Maybe a better name would be "file identifier"?
>> - I wouldn't use `defsubst` (so it can more easily be modified in the
>> future, e.g. in case we add more fields to the attributes or use some
>> other representation for attributes).
> All other accessor functions for file-attributes are defsubsts.
Every `defsubst` should be judged on its own individual value.
This one doesn't seem to be justified.
>> - I would document it more abstractly, mentioning inode and device
>> number only as *examples* of things it might contain.
> There is no intention to use it for anything else. It shall return
> (nthcdr 10 attributes) like all the other file-attributes accessor
> functions return for the respective slots.
I did not suggest changing its implementation. Only its documentation.
The doc should describe the intended semantics of the return value
without documenting how it's implemented.
Stefan
- bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer, Thierry Volpiatto, 2022/10/11
- bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer, Lars Ingebrigtsen, 2022/10/12
- bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer, Stefan Monnier, 2022/10/14
- bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer, Michael Albinus, 2022/10/14
- bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer,
Stefan Monnier <=
- bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer, Michael Albinus, 2022/10/14
- bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer, Eli Zaretskii, 2022/10/14
- bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer, Michael Albinus, 2022/10/14