[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter
From: |
Basil L. Contovounesios |
Subject: |
bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter |
Date: |
Sun, 16 Oct 2022 14:15:48 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Stefan Monnier [2022-10-15 19:31 -0400] wrote:
>>> Hmmm looks like we forgot to mark the `testfn` arg obsolete here with
>>> `advertised-calling-convention` like we did for `map-elt`.
>>> Could you fix that oversight in your patch while you're at it?
>>
>> Sure, but generic functions don't play well with
>> advertised-calling-convention: each subsequent cl-defmethod overwrites
>> the preceding symbol-function, so any existing entry in
>> advertised-signature-table is no longer found after that.
>
> Good point. Not a reason not to add an `advertised-calling-convention`,
Updated patch attached.
> but indeed we should fix that. Could you make a bug report for that?
Done: https://bugs.gnu.org/58563.
Thanks,
--
Basil
0001-Audit-some-plist-uses-with-new-predicate-argument.patch
Description: Text Data
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Basil L. Contovounesios, 2022/10/14
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Basil L. Contovounesios, 2022/10/14
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Stefan Monnier, 2022/10/15
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Basil L. Contovounesios, 2022/10/15
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Stefan Monnier, 2022/10/15
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter,
Basil L. Contovounesios <=
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Stefan Monnier, 2022/10/16
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Basil L. Contovounesios, 2022/10/22
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Stefan Monnier, 2022/10/22
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Basil L. Contovounesios, 2022/10/22
- bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter, Basil L. Contovounesios, 2022/10/22