bug#58543: 29.0.50; The 'q' key is not shown by "C-h ?"

[Philip Kaludercic]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: larsi@gnus.org,  58543@debbugs.gnu.org,  stefankangas@gmail.com
>> Date: Sun, 16 Oct 2022 11:11:20 +0000
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> From: Philip Kaludercic <philipk@posteo.net>
>> >> Cc: Eli Zaretskii <eliz@gnu.org>,  58543@debbugs.gnu.org,  Stefan Kangas
>> >>  <stefankangas@gmail.com>
>> >> Date: Sun, 16 Oct 2022 10:21:05 +0000
>> >> 
>> >> I would therefore remove entry from the "(make-help-screen
>> >> help-for-help" block, and consider some other place to mention the quick
>> >> help buffer.
>> >
>> > How about mentioning it in the "C-h" prompt itself?
>> 
>> Do you mean the "C-h (Type ? for further options)-" prompt?
>
> Yes.  Make it say
>
>   C-h (Type ? for further options, q for quick help)-
>
> or somesuch.

That sounds good.  How about this patch:

>From 8db3c0a25bf88f8e4669fd7e2babc2ff8f5c98b2 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Sun, 16 Oct 2022 15:38:28 +0200
Subject: [PATCH] * src/keyboard.c (echo_add_key): Mention quick-help

---
 src/keyboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/keyboard.c b/src/keyboard.c
index 8ab4a451b4..8386b599c3 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -503,7 +503,7 @@ echo_add_key (Lisp_Object c)
   if ((NILP (echo_string) || SCHARS (echo_string) == 0)
       && help_char_p (c))
     {
-      AUTO_STRING (str, " (Type ? for further options)");
+      AUTO_STRING (str, " (Type ? for further options, q for quick help)");
       AUTO_LIST2 (props, Qface, Qhelp_key_binding);
       Fadd_text_properties (make_fixnum (7), make_fixnum (8), props, str);
       new_string = concat2 (new_string, str);
-- 
2.37.3

Stefan Kangas <stefankangas@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>   C-h (Type ? for further options, q for quick help)-
>>
>> or somesuch.
>
> This is a nit, but is it just me that finds it confusing that the "-" is
> all the way to the right?
>
> IOW, shouldn't it say something like:
>
>     C-h-  (Type ? for further options, q for quick help)
>
> Or now that we have the `help-key-binding' maybe even
>
>     C-h-  [? further options, q quick help]

Ah, I didn't understand what the trailing dash was supposed to signify
so this looks like a good idea.