[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58720: 29.0.50; Improve error reporting of EUDC plist functions
From: |
Basil L. Contovounesios |
Subject: |
bug#58720: 29.0.50; Improve error reporting of EUDC plist functions |
Date: |
Sun, 23 Oct 2022 00:51:00 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
close 58720 29.1
quit
Thomas Fitzsimmons [2022-10-22 14:06 -0400] wrote:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> In https://bugs.gnu.org/58531#19 it was suggested that
>> eudc-plist-member, eudc-plist-get, and eudc-lax-plist-get could signal a
>> more informative wrong-type-argument instead of a generic static error
>> when passed a degenerate plist argument. The attached patch makes this
>> so.
>>
>> An alternative is to simply call plist-member and plist-get directly,
>> relying on them for any error reporting, and not worry about arguments
>> that degenerate further down the list than the point of interest.
>>
>> WDYT? How important is it to name and shame degenerate plists as
>> eagerly as possible in EUDC?
>
> This patch looks good to me. I haven't tested it, but if you have, feel
> free to push to master. (EUDC is not packaged in GNU ELPA, so it's OK
> to use new functions like plistp without providing backward
> compatibility.)
Thanks. Pushed and closing.
Improve error reporting of EUDC plist functions
9db7b11cf7 2022-10-23 00:44:52 +0300
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=9db7b11cf7
--
Basil