bug#51993: 29.0.50; [PATCH] Killing emacsclient terminal with `server-stop-automatically' doesn't prompt to save files

[Jim Porter]

On 10/21/2022 11:57 PM, Eli Zaretskii wrote:
> > Date: Fri, 21 Oct 2022 20:46:47 -0700
> > Cc: larsi@gnus.org, 51993@debbugs.gnu.org, gregory@heytings.org
> > From: Jim Porter <jporterbugs@gmail.com>
> >
> > The issue in the quote above is that if you enable automatic server
> > shutdown in Emacs 29, it changes the behavior of exiting an emacsclient
> > even when it wouldn't stop the server (i.e. when there are other active
> > clients). That's surprising to me, I wouldn't expect that setting to
> > affect cases when it decides *not* to kill the Emacs daemon.
>
> Sounds like a bug to me, because it contradicts what the doc string
> says.

That's how it seems to me too. In that case, I can update the patch I 
attached in my original message[1] to fix the bug. If we want to 
preserve the current behavior that Emacs 29 has exactly, we could also 
add a separate setting for how to handle killing the non-last client; 
then the two would be independently customizable. I'm not sure this is 
necessary, but if others think it is, I'm happy to write a patch for it.

[1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-11/msg01702.html