bug#58844: 29.0.50; Font lock features for js/ts-mode

[Theodor Thornhill]

Yuan Fu <casouri@gmail.com> writes:

>> On Oct 28, 2022, at 12:27 PM, Theodor Thornhill <theo@thornhill.no> wrote:
>> 
>> Hi Yuan!
>> 
>> I've added more font lock features to the js and ts modes.  I think they
>> can serve as a suitable starting point for the features, and serve as
>> inspiration to other modes, until we settle on a standard here.
>> 
>> Thanks,
>> 
>> Theo
>> 
>> <0001-Add-in-new-font-lock-features-in-js-ts-mode.patch>
>
> Thanks! Minor bikeshed: I think singular is slightly better. Ie,
> comment instead of comments. No need to modify your patch, if you
> agree I can change them myself. Also treesit-font-lock-feature-list
> should contain three sublist, each representing a decoration level,
> that’s how we get two types of customization in the same time. I can
> fix that too.
>

Sure, just go ahead!

> While we’re at it, are there specific reasons why you write many indent rules 
> in two lines, like this:
>
> ((parent-is "ternary_expression")
>       parent-bol ,ts-mode-indent-offset)
>
> ?
>
> I think they should be in one line for clarity and space efficiency.

Sure! The only reason was that you asked me to cram it into short lines,
hehe ;-) Do you want another patch for that?


BTW, disregard the other bug. That's the same one...

-- 
Thanks,

Theo