bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash direct


From: Eli Zaretskii
Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice
Date: Sun, 30 Oct 2022 20:02:54 +0200

> From: Mike Kupfer <mkupfer@alum.berkeley.edu>
> cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com
> Date: Sun, 30 Oct 2022 10:40:24 -0700
> 
> Eli Zaretskii wrote:
> 
> > I just thought you'd be able to call copy-directory, similarly (but
> > differently) to what rename-file does, instead of using your
> > lambda-function.
> 
> Ah, of course.  Thanks, yes, that's cleaner.  How does the attached
> patch look?

Looks good, but maybe add to the comment the reason _why_ we don't use
rename-file for directories.  You explained _what_ we do, but not
_why_.

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]