[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58899: [PATCH v1] Add the "doas" alias to eshell.
From: |
Brian Cully |
Subject: |
bug#58899: [PATCH v1] Add the "doas" alias to eshell. |
Date: |
Mon, 31 Oct 2022 12:01:47 -0400 |
Jim Porter <jporterbugs@gmail.com> writes:
> I'd say go with "Tramp" like you did in your patch. Since you're
> modifying code near most of the existing usages of "TRAMP", now would
> probably be a good time to fix that everywhere in the file too.
I've made this change in a separate patch so as not to muddy history too
much. If you'd prefer everything rolled up, I can do that, too.
> Since the 'eshell/doas' and 'eshell/sudo' functions are so similar, I
> definitely think it would make sense to share as much code as possible
> here. In particular, you could also add support for "--shell" to
> 'eshell/sudo'.
Done.
> There are some existing tests in test/lisp/eshell/em-tramp-tests.el, so
> I think it should be fairly safe to adjust 'eshell/sudo'; the regression
> tests should catch any problems. (Well ok, *some* problems.) It would
> probably be good to add some simple tests for 'eshell/doas' too.
I've added two more tests to cover the shell arguments to ‘eshell/sudo’,
plus equivalent tests for the doas functionality.
In addition, this patch adds a comment to NEWS and updates the Texinfo
docs. This is my first time messing with those files and I'm not very
familiar with Texinfo; if I've messed something up, let me know.
-bjc
v2-0001-Add-the-doas-alias-to-eshell.patch
Description: Text Data
v2-0002-lisp-eshell-em-tramp.el-Rename-TRAMP-to-Tramp.patch
Description: Text Data