[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows
From: |
Danny Freeman |
Subject: |
bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows |
Date: |
Fri, 18 Nov 2022 08:39:13 -0500 |
Eli Zaretskii <eliz@gnu.org> writes:
>
> Not sure I understand why this matters in the context of this
> discussion. We need to make eglot--path-to-uri produce valid file://
> URL on MS-Windows and on Posix systems, right? Then why does it
> matter how URI schema are defined? What am I missing?
The current eglot--path-to-uri implementation should produce a valid
file:// url unless what it receives is already a URL.
So it could receive something like:
/home/user/project/whatever.c
d:/what/home/is/on/windows/whatever.c
Both of which should be transformed into file:// URLs
OR what it receives may already be a URL like
zipfile:home/user/project.zip::/path/in/zip.c
If it receives a URL, we want to pass it along, and not transform it
into a file:// URL.
If it is a full windows path, we DO want to turn that into a file url.
So how do we detect that is is a windows path, and not a URL already?
That's what I was trying to get at in the other message you replied to.
Just checking the user's current OS is not enough, because this function
could also receive a URL on Windows.
--
Danny Freeman
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Arash Esbati, 2022/11/17
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Eli Zaretskii, 2022/11/17
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Augusto Stoffel, 2022/11/17
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Danny Freeman, 2022/11/17
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Augusto Stoffel, 2022/11/17
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Eli Zaretskii, 2022/11/18
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows,
Danny Freeman <=
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Eli Zaretskii, 2022/11/18
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Danny Freeman, 2022/11/18
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Arash Esbati, 2022/11/18
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Eli Zaretskii, 2022/11/18
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, João Távora, 2022/11/23
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Danny Freeman, 2022/11/24
- bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, João Távora, 2022/11/24
bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows, Arash Esbati, 2022/11/17