bug#62009: 29.0.60; Emacs crashes on setf symbol-name

[Eli Zaretskii]

> Date: Sat, 11 Mar 2023 15:16:36 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Daniel Mendler <mail@daniel-mendler.de>, philipk@posteo.net, 
>     michael_heerdegen@web.de, rpluim@gmail.com, monnier@iro.umontreal.ca, 
>     62009@debbugs.gnu.org, arstoffel@gmail.com
> 
> 
> >
> > Sorry, I object to any change to cater for this use case.
> >
> 
> IMO a reasonable change here would be to update the docstring of 
> symbol-name, which only says "Return SYMBOL's name, a string.", with a 
> warning similar to the one in the manual:
> 
> Warning: Changing the string by substituting characters does change the 
> name of the symbol, but fails to update the obarray, so don't do it!

That is okay, of course.  My objection was to the code changes.

> Perhaps we could also explicitly mention, in the docstring and/or in the 
> manual, that doing that can also crash Emacs.

I think being a bit vague here and talking about "dangers" should be
good enough, since not every such code will crash, and probably also
not on every platform and in every build configuration.