bug#28064: eshell-cmpl should not auto-complete ~/./

[Jim Porter]

On 8/12/2017 6:44 AM, Yegor Timoshenko wrote:
> M-x eshell
> Type `cd ~/.` and press TAB.
>
> It will auto-complete to `cd ~/./`. I don't think it's useful.

A much-delayed thanks for reporting this. I looked into this, and it was 
due to 'eshell-expand-user-reference' calling 'expand-file-name' on the 
argument. This meant that when you press TAB, the "~/." gets converted 
into "/home/user" before passing the command to Pcomplete. Then 
Pcomplete would incorrectly assume you wanted to complete "/home/user", 
which just becomes "/home/user/".

Attached is a fix. Normally I'd write a regression test for this, but I 
haven't come up with a good way to do this without messing up the user's 
real home directory...

0001-Don-t-over-normalize-file-names-starting-with-in-Esh.patch
Description: Text document