bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode


From: Wilhelm Kirschbaum
Subject: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
Date: Sun, 12 Mar 2023 11:54:33 +0200
User-agent: mu4e 1.9.3; emacs 30.0.50


Eli Zaretskii <eliz@gnu.org> writes:

From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
Cc: 61996@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no
Date: Sat, 11 Mar 2023 20:01:32 +0200

> Please accompany the changes with a commit log message > according > to our conventions (see CONTRIBUTE for the conventions; > search for > "ChangeLog" there). In this case, just "New file" log should > be
> sufficient for the new files you add.
>
Thanks, was not aware of it. I hope it is correct in the new patches.

Yes, it is.  Thanks.

The new patches should hopefully cover all of the above issues.

Almost there. Byte compiler shows warnings, which I think are real
problems in the code:

  In elixir-ts--call-parent-start:
progmodes/elixir-ts-mode.el:459:38: Warning: Unused lexical argument `node' progmodes/elixir-ts-mode.el:463:15: Warning: reference to free variable `parent'

  In elixir-ts--forward-sexp:
progmodes/elixir-ts-mode.el:482:8: Warning: reference to free variable `heex-ts--sexp-regexp'

Ah, not sure how I missed them. The new patches have further tweaks and
should resolve the above issue.

Attachment: 0001-Add-heex-ts-mode-Bug-61996.patch
Description: Add heex-ts-mode

Attachment: 0002-Add-elixir-ts-mode-Bug-61996.patch
Description: Add elixir-ts-mode


reply via email to

[Prev in Thread] Current Thread [Next in Thread]