bug#62402: 30.0.50; Emacs crashes on popup menu selection

[Eshel Yaron]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: 62402@debbugs.gnu.org
>> Date: Thu, 23 Mar 2023 16:56:20 +0800
>> From:  Ruijie Yu via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> FTR, I cannot reproduce this issue on PGTK GNU/Linux with 30.0.50
>> (c6bfffa9fe1af7f4f806e5533ba5f3c33476cf9a), so this issue might be OS-
>> or WM-specific.
>
> And I cannot reproduce on MS-Windows, so I think this is indeed macOS
> specific.

Thanks for looking into it.  Indeed it seems to be a problem specific to
MacOS.  To shed some more light I've rebuilt Emacs with CFLAGS="-g3 -O0"
and ran it under lldb, which shows the following backtrace:

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS 
(code=1, address=0x3)
  * frame #0: 0x00000001000aebad emacs`AREF(array=0x0000000000000000, idx=0) at 
lisp.h:1947:10
    frame #1: 0x00000001000af660 
emacs`find_and_return_menu_selection(f=0x00000001100dee30, keymaps=true, 
client_data=0x000000011089b888) at menu.c:985:11
    frame #2: 0x0000000100380f2b emacs`-[EmacsMenu 
runMenuAt:forFrame:keymaps:](self=0x00006000017007c0, 
_cmd="runMenuAt:forFrame:keymaps:", p=(x = 2, y = 506), f=0x00000001100dee30, 
keymaps=true) at nsmenu.m:767:9
    frame #3: 0x0000000100381f00 emacs`ns_menu_show(f=0x00000001100dee30, x=2, 
y=2, menuflags=1, title=0x0000000000000000, error=0x00007ff7bfefce80) at 
nsmenu.m:1067:9
    frame #4: 0x00000001000b1203 
emacs`x_popup_menu_1(position=0x000000011804dcb3, menu=0x000000011804e003) at 
menu.c:1410:17
    frame #5: 0x00000001000b15a2 
emacs`Fx_popup_menu(position=0x000000011804dcb3, menu=0x000000011804e003) at 
menu.c:1474:10
    frame #6: 0x0000000100247c58 emacs`eval_sub(form=0x000000011804dd23) at 
eval.c:2503:15
    ...

It seems that the (MacOS-specific) function
`find_and_return_menu_selection` in menu.c tries to access the global
variable `menu_items` before it's initialized.  I'm not sure when or
where it should be initialized though :(

-- 
Eshel