[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63818: 27.1; unbound local variables break python-util-clone-local-v
From: |
kobarity |
Subject: |
bug#63818: 27.1; unbound local variables break python-util-clone-local-variables |
Date: |
Thu, 01 Jun 2023 23:36:24 +0900 |
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (Gojō) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
Eli Zaretskii wrote:
> > From: Ernesto Alfonso <erjoalgo@gmail.com>
> > Date: Wed, 31 May 2023 17:47:16 -0400
> > SCRIPT=$(cat <<EOF
> > (progn
> > (require 'python)
> > (defvar-local my-local-var 0)
> > (makunbound 'my-local-var)
> > (python-util-clone-local-variables (current-buffer)))
> > EOF
> > )
> > emacs -Q --eval "${SCRIPT}"
> >
> >
> > Suggested patch to '#python-util-clone-local-variables in python.el
> >
> >
> > 5205c5205,5206
> > < (and (symbolp (car pair))
> > ---
> > > (and (listp pair)
> > > (symbolp (car pair))
> >
>
> Stefan and kobarity, any comments?
I'm not familiar with this area, but I looked at the Orgmode code. It
was changed to use pcase.
(defun org-clone-local-variables (from-buffer &optional regexp)
"Clone local variables from FROM-BUFFER.
Optional argument REGEXP selects variables to clone."
(dolist (pair (buffer-local-variables from-buffer))
(pcase pair
(`(,name . ,value) ;ignore unbound variables
(when (and (not (memq name org-unique-local-variables))
(or (null regexp) (string-match-p regexp (symbol-name name))))
(ignore-errors (set (make-local-variable name) value)))))))
This change seems to be based on the following discussion.
https://lists.gnu.org/archive/html/emacs-orgmode/2017-06/msg00037.html
Maybe we can adopt the same approach?