[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63825: 29.0.90; The header line should be hidden when empty
From: |
Eshel Yaron |
Subject: |
bug#63825: 29.0.90; The header line should be hidden when empty |
Date: |
Fri, 02 Jun 2023 21:53:45 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Eli Zaretskii <eliz@gnu.org> writes:
>> The way I read Eli's above message, it boils down to extending the C
>> function `window_wants_mode_line` with a couple of special cases.
>> Something like the following (mildly tested):
> Thanks, this is an elegant solution. A few minor comments:
Thanks for reviewing, I'm attaching an updated patch below.
Regarding this comment:
>> +/**
>> + * null_header_line_format:
>> + *
>> + * Return 1 when header line format F indicates that the header line
>> + * should not be displayed at all.
> We usually say "Return non-zero", not 1.
I've changed the wording accordingly, note that some other functions
that return `bool` in src/window.c currently say "Return 1",
e.g. `window_wants_header_line`.
> And finally, please accompany the change with a suitable commit log
> message, an entry in NEWS, and a change for the ELisp manual.
Sure, here's the new patch:
0001-Avoid-header-line-with-some-empty-non-nil-formats.patch
Description: Text Data
- bug#63825: 29.0.90; The header line should be hidden when empty, Spencer Baugh, 2023/06/01
- bug#63825: 29.0.90; The header line should be hidden when empty, Eli Zaretskii, 2023/06/01
- bug#63825: 29.0.90; The header line should be hidden when empty, Eshel Yaron, 2023/06/01
- bug#63825: 29.0.90; The header line should be hidden when empty, Spencer Baugh, 2023/06/01
- bug#63825: 29.0.90; The header line should be hidden when empty, Eli Zaretskii, 2023/06/01
- bug#63825: 29.0.90; The header line should be hidden when empty, Spencer Baugh, 2023/06/01
- bug#63825: 29.0.90; The header line should be hidden when empty, Eshel Yaron, 2023/06/02
- bug#63825: 29.0.90; The header line should be hidden when empty, Eli Zaretskii, 2023/06/02
- bug#63825: 29.0.90; The header line should be hidden when empty,
Eshel Yaron <=
- bug#63825: 29.0.90; The header line should be hidden when empty, Eli Zaretskii, 2023/06/03
- bug#63825: 29.0.90; The header line should be hidden when empty, Eshel Yaron, 2023/06/03
- bug#63825: 29.0.90; The header line should be hidden when empty, Eli Zaretskii, 2023/06/04
- bug#63825: 29.0.90; The header line should be hidden when empty, Eshel Yaron, 2023/06/04
- bug#63825: 29.0.90; The header line should be hidden when empty, Eli Zaretskii, 2023/06/06
- bug#63825: 29.0.90; The header line should be hidden when empty, Eshel Yaron, 2023/06/06
- bug#63825: 29.0.90; The header line should be hidden when empty, Eli Zaretskii, 2023/06/02