bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unre


From: Vladimir Sedach
Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers
Date: Mon, 26 Jun 2023 22:39:50 -0600
User-agent: mu4e 1.4.15; emacs 28.2

Fix shell-dirtrack-mode showing up as enabled in unrelated buffers

shell-dirtrack-mode always shows up in unrelated buffers.

Steps to reproduce:
1. emacs -q
2. M-x shell
3. describe-mode (C-h m) in *scratch* or *GNU Emacs*

This is because shell-dirtrack-mode is aliased to shell-dirtrackp,
which has default value t.

Changes in this patch:
mark shell-dirtrackp obsolete
replace existing occurrences of shell-dirtrackp with shell-dirtrack-mode
add :interactive (shell-mode) suggestion to shell-dirtrack-mode

shell-dirtrack-mode is still turned on by default. There is an
explicit call to (shell-dirtrack-mode 1) in the definition of
shell-mode.

Definition of shell-dirtrack-mode is moved to quiet warning about
reference to free variable ‘shell-dirtrack-mode’.

Note: I am not sure what to put for WHEN on the obsolete variable.
Does that get filled in when merging?

--
Vladimir Sedach

Attachment: 0001-test-lisp-shell-tests.el-added-tests-for-shell-dirtr.patch
Description: Text Data

Attachment: 0002-Fix-shell-dirtrack-mode-showing-up-as-enabled-in-unr.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]