[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66470: 29.1; Provide Urdu input method
From: |
Eli Zaretskii |
Subject: |
bug#66470: 29.1; Provide Urdu input method |
Date: |
Sat, 04 Nov 2023 10:39:05 +0200 |
> From: Rahguzar <rahguzar@zohomail.eu>
> Cc: 66470@debbugs.gnu.org
> Date: Sun, 29 Oct 2023 17:27:38 +0100
>
> Thanks for the review. I have made the changes you asked for, please
> let me know of other changes need.
Below.
> Subject: [PATCH] Input methods for Urdu, Pashto and Sindhi
>
> * lisp/leim/quail/pakistan.el (quail):
> ("urdu-keyboard"): new input method
> ("urdu-phonetic-keyboard"): new input method
> ("urdu-custom"): new input method
> ("sindhi-keyboard"): new input method
> ("pashto-keyboard"): new input method
These should be brought together, and the description should start
with a capitalized letter and end with a period. Like this:
* lisp/leim/quail/pakistan.el ("urdu-keyboard")
("urdu-phonetic-keyboard", "urdu-custom", "sindhi-keyboard")
("pashto-keyboard"): New input methods
> ; (pakistan--define-quail-rules): helper function
> ; (pakistan--make-setter): helper function
> ; (pakistan--regenerate-translations): helper function
> ; (pakistan--set-prefixes): helper function
> ; (pakistan--set-numeral-translations):
Why are there semi-colons here?
> (pakistan-urdu-input): new customization group
> (pakistan-urdu-prefixes): new custom variable
> (pakistan-urdu-translations): new custom variable
> (pakistan-urdu-diacritics-and-other-symbols): new custom var
> (pakistan-urdu-poetic-symbols): new custom var
> (pakistan-urdu-religious-symbols): new custom var
> (pakistan-extra-balochi-brahui-translations): new custom var
> (pakistan-extra-pashto-translations): new custom var
> (pakistan-extra-sindhi-translations): new custom var
> (pakistan-extra-saraiki-hindko-translations): new custom var
> (pakistan-urdu-use-roman-digits): new custom var
> (pakistan): new package
This should again be a single entry about multiple variables, since
they all share the same description: "New custom variable".
While compiling this, I get byte-compiler warnings:
In pakistan--define-quail-rules:
leim/quail/pakistan.el:199:41: Warning: reference to free variable
`pakistan-urdu-prefixes'
In pakistan--regenerate-translations:
leim/quail/pakistan.el:215:33: Warning: reference to free variable
`pakistan-urdu-translations'
leim/quail/pakistan.el:217:4: Warning: reference to free variable
`pakistan-urdu-diacritics-and-other-symbols'
leim/quail/pakistan.el:218:33: Warning: reference to free variable
`pakistan-urdu-poetic-symbols'
leim/quail/pakistan.el:219:33: Warning: reference to free variable
`pakistan-urdu-religious-symbols'
leim/quail/pakistan.el:220:33: Warning: reference to free variable
`pakistan-extra-balochi-translations'
leim/quail/pakistan.el:221:33: Warning: reference to free variable
`pakistan-extra-pashto-translations'
leim/quail/pakistan.el:222:33: Warning: reference to free variable
`pakistan-extra-saraiki-translations'
leim/quail/pakistan.el:223:33: Warning: reference to free variable
`pakistan-extra-sindhi-translations'
- bug#66470: 29.1; Provide Urdu input method,
Eli Zaretskii <=
- bug#66470: 29.1; Provide Urdu input method, Rahguzar, 2023/11/04
- bug#66470: 29.1; Provide Urdu input method, Eli Zaretskii, 2023/11/04
- bug#66470: 29.1; Provide Urdu input method, Rahguzar, 2023/11/04
- bug#66470: 29.1; Provide Urdu input method, Eli Zaretskii, 2023/11/04
- bug#66470: 29.1; Provide Urdu input method, Rahguzar, 2023/11/04
- bug#66470: 29.1; Provide Urdu input method, Eli Zaretskii, 2023/11/11
- bug#66470: 29.1; Provide Urdu input method, Rahguzar, 2023/11/11
- bug#66470: 29.1; Provide Urdu input method, Eli Zaretskii, 2023/11/18
- bug#66470: 29.1; Provide Urdu input method, Rahguzar, 2023/11/18